-
Notifications
You must be signed in to change notification settings - Fork 35
chore(framework): Remove the Bridge package and all its functionalities #6863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nonast
wants to merge
62
commits into
vm-lang/chore/bridge-removal
Choose a base branch
from
vm-lang/chore-issue-6847-remove-bridge
base: vm-lang/chore/bridge-removal
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(framework): Remove the Bridge package and all its functionalities #6863
nonast
wants to merge
62
commits into
vm-lang/chore/bridge-removal
from
vm-lang/chore-issue-6847-remove-bridge
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
Just factorising a bit.
✅ Vercel Preview Deployment is ready! |
miker83z
reviewed
May 29, 2025
…6847-remove-bridge
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
muXxer
reviewed
Jun 4, 2025
DaughterOfMars
approved these changes
Jun 4, 2025
richardmands
approved these changes
Jun 4, 2025
muXxer
approved these changes
Jun 4, 2025
piotrm50
approved these changes
Jun 5, 2025
FranCerdan
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Issues related to our CI pipeline
documentation
Improvements or additions to documentation
sc-platform
Issues related to the Smart Contract Platform group.
vm-language
Issues related to the VM & Language Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR completely removes a package from the iota-framework that was never enabled/used: the
bridge
.Associated to that there was a whole set of tools to setup and run the bridge infra:
iota-bridge
iota-bridge-cli
iota-bridge-indexer
bridge
directory for managing the EVM sideiota-framework
.bridge
was removed (because it was never set to true), while thebridge_should_try_to_finalize_committee
flag was left because it was previously set toSome
(and removing this means we would modify previous protocol config digests, discussion)EndOfEpochTransactionKind
were removed:BridgeStateCreate
andBridgeCommitteeInit
. Transactions of these kinds SHOULD NOT exist in Devnet, Testnet and Mainnet because thebridge
protocol flag was never enabled. This has implications on all crates related to public APIs.EpochStartConfiguration
was modified to removebridge_obj_initial_shared_version
andbridge_committee_initiated
.bridge
, we need to support the replay of such process.bridge
package snapshot).bridge
package was verified before being published. In order to pass the verification, the0xb::bridge::create
function should be treated as privileged because it uses a UID parameter to create a new object (not a valid operation normally). So, this function is kept in the list ofFUNCTIONS_TO_SKIP
in theiota-verifier
. This also means we SHOULD NOT reuse the0xb
address in the future or handle it carefully.check_manifest_against_tomls
testmanifest.json
match the metadata in theMove.toml
files of theiota-framework
packages.in the manifest and then use those files for the check. This allows us to modify name, id and remove packages every time we create a new protocol version.
manifest.json
so that the fetch of commits during thecheck_manifest_against_tomls
test execution would be more efficient (it fetches each commit instead of the whole history). Moreover, some revs in the manifest were pointing to commits not belonging to any branch (squashed), so these were manually updated.TODO
Links to any relevant issues
fixes #6847
Type of change
How the change has been tested
CI.
Infrastructure QA
TODO @iotaledger/infrastructure
Release Notes
bridge_obj_initial_shared_version
andbridge_committee_initiated
fromEpochStartConfiguration
BridgeReadApi
includinggetLatestBridge
andgetBridgeObjectInitialSharedVersion
. RemovedEndOfEpochTransactionKind::BridgeStateCreate
andEndOfEpochTransactionKind::BridgeCommitteeInit
variants.EndOfEpochTransactionKind::BridgeStateCreate
andEndOfEpochTransactionKind::BridgeCommitteeInit
variants and related types.bridge-committee-init
,validator register-bridge-committee
andupdate-bridge-committee-node-url
commands.EndOfEpochTransactionKind::BridgeStateCreate
andEndOfEpochTransactionKind::BridgeCommitteeInit
variants.